4 ms·
The `Co-authored-by` trailer is your friend here. Even if you completely rewrite their code, give them coauthor credit in the commits and they’ll get the satisf
by tomstuart 4y ago
The `Co-authored-by` trailer is your friend here. Even if you completely rewrite their code, give them coauthor credit in the commits and they’ll get the satisfaction of seeing their face in the commit history without the hassle of actually addressing all your feedback. https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors https://docs.github.com/en/pull-requests/committing-changes-...
- masklinn 4y agoIf only two people are involved in the PR you don't even need "Co-Authored-By": unless you --reset-author, it's not going to get blown up by updating the commits, only "committer" is.
- captn3m0 4y agoFor squash merges, GitHub will autofill the Co-Authored-By in the merge commit, but it is up to you to keep it there.
- mook 4y agoWouldn't making commits on top of their (untouched) commits fine too? When creating PRs, there is a checkbox to allow repository committers to push into the PR branch. That preserves the original author credit (and any GPG signatures), but moves things along. If that's not enabled, making a new PR based on the same commits works too.
- rurban 4y agoNot for a GNU project, where the PR author didn't file a copyright assignment via snail mail yet. Such PR's could need months.