5 ms·

When I was writing a book for O'Reilly about the GitHub API, I interviewed a bunch of people from GitHub. One of them told me a surprising story: he said that o

by xrd 5y ago

When I was writing a book for O'Reilly about the GitHub API, I interviewed a bunch of people from GitHub. One of them told me a surprising story: he said that often they ask people to write the PR BEFORE writing any code at all. The PR should be created with zero commits. That way they can discuss the ideas, implementation plan, impact, without even thinking about the code. After hearing this, I believe that a PR should be changed dozens of times even if it is a one line change of code. PRs can reflect a million changing things, and I often update a PR months after the code is done because new information has come in that makes the code change need more context. More stories like this could help your cause, no?

brianwawok 5y ago
That sounds like a solution for someone without a bug tracking tool. All of the discussion should totally happen outside of GitHub in a proper story tracking tool.
- pxeger1 5y ago
  I guess the point is that GitHub already has a bug tracking tool. So, in a way, they are perfectly integrated.
  - electroly 5y ago
    Yeah but PRs aren't the bug tracking tool. Issues are. Why wouldn't this be discussed in the issue, rather than the PR?
    - xigoi 5y ago
      To me, an issue implies “please do this”, whereas a PR implies “I'm going to do it myself, just tell me if you're going to accept it”.
gitgud 5y ago
> The PR should be created with zero commits Doesn't a PR need a commit to be able to create it?
- xrd 5y ago
  Just a branch, no commit needed.