2 ms·

>you use the stdlib * First you construct a request, and check the error on that * Then you "Do" the request and check the error on that * Then you check the

>you use the stdlib * First you construct a request, and check the error on that * Then you "Do" the request and check the error on that * Then you check the status code (you did check it, right?) * Then you deserialize the response and check the error on that * Then you close the response body (you did remember to close it, right?) and check the error on that Actually making an HTTP request with Go stdlib is a many-stage process and it is very easy to screw up or forget one of the steps. I see it all the time. Actually I have seen outages related to people being too zealous and reporting errors related to closing the response body on otherwise successful requests.

Cthulhu_ 4y ago
> Actually I have seen outages related to people being too zealous and reporting errors related to closing the response body on otherwise successful requests. I kinda get it though, because the compiler or linters will show that as a warning or error going "bruh you forgot to handle this error", and as a perfectionist one wants to get rid of all of those. I mean IMO those should be logged anyway, if only so you get some data on how often it happens, if there's anything that can be done about it, and if it's harmless, to ignore the error - but make it explicit.