3 ms·

I think your answered your own question with saying you have a monorepo on GitHub. Like it’s not designed for that at all? That’s the main reason I’m not yet pu

I think your answered your own question with saying you have a monorepo on GitHub. Like it’s not designed for that at all? That’s the main reason I’m not yet pushing for monorepos in our org, because it looks like it’ll be inviting trouble if we are still using GitHub for it. Also you’re not doing trunk? I mean I get it it’s hard but sounds like a no brainer thing to stop doing as soon as possible..

ollien 5y ago
> Like it’s not designed for that at all? The PR workflow certainly isn't, but we're far from the only company using them (Dropbox comes to mind). It's surprising to see it not fully supported. > Also you’re not doing trunk? I mean I get it it’s hard but sounds like a no brainer thing to stop doing as soon as possible.. No, unfortunately not. Trust me, you're preaching to the choir :) But unfortunately, long-lived branches is the workflow we're stuck with at the moment (we constantly merge commits forward, but it's a manual process). That said, even if we were using short-lived feature-branches, you wouldn't be able to know from the PR view if a commit was to a feature branch or not, so the criticism still applies.