3 ms·
> because of a lack of volunteers to maintain all of nixpkgs They need some serious shakeup from that side in my opinion. I've had PRs open for trivial things
by viraptor 5y ago
> because of a lack of volunteers to maintain all of nixpkgs
They need some serious shakeup from that side in my opinion. I've had PRs open for trivial things for >1mth. Issues, security stuff, new packages. They don't even document how to mark something as a security issue. PRs that mention CVE do that, but otherwise I couldn't find anything so for example https://github.com/NixOS/nixpkgs/pull/161198 https://github.com/NixOS/nixpkgs/pull/161198 which includes a security fix is still waiting.
If they can't pull off the reviews with 577 people (https://github.com/orgs/NixOS/people https://github.com/orgs/NixOS/people), then they need to start rejecting new ones or relaxing the automerge rules - at the very least on simple version bumps. Flakes at least provide some solution for easily including the 3rd party software without merging.
- ris 5y ago> They don't even document how to mark something as a security issue Only committers can add those labels - it's probably best to flag it in the PR subject line and hope a committer notices it and turns it into a label. Edit: more... When it comes to "trivial" changes I think there's an ironic "zone of triviality" where, if other reviewers are anything like me, reviews of more serious bumps will get prioritized. A minor bump is so likely to get superseded very soon that I'll prioritize something that is more likely to cause breakages and require attention. Some package areas (e.g. python packages) do periodic mass bumps of packages to catch the stragglers. There are of course issues though drawing attention to "trivial" changes that are subtly important like, as you say, security issues.