7th gen keyboard is the best in the X1 Carbon history, 8th gen had reliability problems, and the current generation (9th) is very very good, if you are ok with

7th gen keyboard is the best in the X1 Carbon history, 8th gen had reliability problems, and the current generation (9th) is very very good, if you are ok with the reduced key travel. I happen to like it, but it is really a matter of personal preference.