5 ms·

The git issue is hard to follow. They reference having GPL'ed license code, but the author claims there is only LGPL code in it. The issue poster then says at o

by kop316 4y ago

The git issue is hard to follow. They reference having GPL'ed license code, but the author claims there is only LGPL code in it. The issue poster then says at one point GPLed code was used....but then doesn't show commits where it was added or removed? There is an additional git issue that is referenced, but this only talks about the original license of the repository. I could just be bad at following what is going on too, since this is the first time I have seen this.

exikyut 4y ago
Following the link to issue 60 posted elsewhere, I found someone posted exactly that type of list in a comment: https://github.com/cheat-engine/cheat-engine/issues/60#issuecomment-942071225 https://github.com/cheat-engine/cheat-engine/issues/60#issue...
naoqj 4y ago
https://github.com/cheat-engine/cheat-engine/issues/60#issuecomment-942071225 https://github.com/cheat-engine/cheat-engine/issues/60#issue...
- kop316 4y ago
  Ahh, that helps a bunch. Thank you!
- lawl 4y ago
  Just checked one of those at random: https://github.com/cheat-engine/cheat-engine/blame/master/Cheat%20Engine/tcclib/tcctools.c https://github.com/cheat-engine/cheat-engine/blame/master/Ch... > modify it under the terms of the GNU Lesser General Public > * License as published by the Free Software Foundation; LGPL, not GPL. No shady stuff going on either, https://github.com/mirror/tinycc/blob/mob/tcctools.c https://github.com/mirror/tinycc/blob/mob/tcctools.c sais the same thing. Edit: texi2pod.pl however does seem to be GPL, and not LGPL: https://github.com/mirror/tinycc/blob/mob/texi2pod.pl https://github.com/mirror/tinycc/blob/mob/texi2pod.pl however, perl isn't linked, so there's probably a way out there. il-opcodes does seem to be GPL2+, and the header arguably would end up in the binary thus forcing everything to be GPL? https://github.com/mirror/tinycc/blob/mob/il-opcodes.h https://github.com/mirror/tinycc/blob/mob/il-opcodes.h Edit 2: I think I've resolved this: Fabrice Bellard already agreed to relicense under a permissive license, see: https://github.com/mirror/tinycc/blob/mob/RELICENSING https://github.com/mirror/tinycc/blob/mob/RELICENSING Thus, I think it would be really hard to argue that there's any problem left, since the only file here that could be in violation (il-opcodes) is authored by fabrice bellard and arguably already permissively licensed. Case closed.
  - throwaway2037 4y ago
    Authored by Fabrice Bellard: https://github.com/cheat-engine/cheat-engine/blob/master/Cheat%20Engine/tcclib/il-opcodes.h https://github.com/cheat-engine/cheat-engine/blob/master/Che... Says: * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. That looks like GPL 2+ to me. Please correct me if I misunderstand.
    - mytherin 4y ago
      Note the "(at your option) any later version" clause. The COPYING file contains this: * GNU LESSER GENERAL PUBLIC LICENSE * Version 2.1, February 1999 * [This is the first released version of the Lesser GPL. It also counts * as the successor of the GNU Library Public License, version 2, hence * the version number 2.1.] It seems to me that code is licensed under LGPL 2.1, as was mentioned by the cheat-engine author in the github issues. Edit: Fabrice Bellard is also the author of libtcc, who has chosen to release that project under LGPL, so this is irrelevant to begin with. The file is LGPL.
      - tedivm 4y ago
        The copying file was added years later and not by the same author as the original license. It looks like tcclib itself messed up somewhere along the lines here. Also, "any later version" is any later version of the same license. LGPL and GPL are two separate licenses- you can't switch GPL to LGPL using this clause.
      - toast0 4y ago
        GNU Library Public License (LPL?) != GNU General Public License (GPL)
        klodolph 4y ago
        "Lesser General Public License" I assume that it used to stand for "library", and this was changed to discourage people from thinking of this library as the default license for libraries, and consider using the GPL instead. For example, the GNU Readline library is GPL, and this is reportedly the reason why CLISP is also GPL'd.
- nightpool 4y ago
  This comment only points out MPL or LGPL licensed code. tcclib contains a COPYING file that affirms all code distributed as part of tcclib is available under the LGPL. LuaSyntax.pas and SynHighlighterAA.pas are available under the MPL. The only actually GPL-licensed file in that list, obsolete_ntifs.h, doesn't exist in the repo. If you can find a version of CheatEngine that includes that file, presumably that would be a GPL violation, but that would have to rely on an analysis of how integrated the DBKKernel component is with the rest of the CheatEngine system.
  - formerly_proven 4y ago
    obsolete_ntifs.h seems to only contain Windows API definitions, so it is doubtful that the GPL applies to using it (Oracle v. Google).

by kop316 4y ago

exikyut 4y ago

Following the link to issue 60 posted elsewhere, I found someone posted exactly that type of list in a comment: https://github.com/cheat-engine/cheat-engine/issues/60#issuecomment-942071225 https://github.com/cheat-engine/cheat-engine/issues/60#issue...

naoqj 4y ago

https://github.com/cheat-engine/cheat-engine/issues/60#issuecomment-942071225 https://github.com/cheat-engine/cheat-engine/issues/60#issue...

kop316 4y ago
Ahh, that helps a bunch. Thank you!
lawl 4y ago
Just checked one of those at random: https://github.com/cheat-engine/cheat-engine/blame/master/Cheat%20Engine/tcclib/tcctools.c https://github.com/cheat-engine/cheat-engine/blame/master/Ch... > modify it under the terms of the GNU Lesser General Public > * License as published by the Free Software Foundation; LGPL, not GPL. No shady stuff going on either, https://github.com/mirror/tinycc/blob/mob/tcctools.c https://github.com/mirror/tinycc/blob/mob/tcctools.c sais the same thing. Edit: texi2pod.pl however does seem to be GPL, and not LGPL: https://github.com/mirror/tinycc/blob/mob/texi2pod.pl https://github.com/mirror/tinycc/blob/mob/texi2pod.pl however, perl isn't linked, so there's probably a way out there. il-opcodes does seem to be GPL2+, and the header arguably would end up in the binary thus forcing everything to be GPL? https://github.com/mirror/tinycc/blob/mob/il-opcodes.h https://github.com/mirror/tinycc/blob/mob/il-opcodes.h Edit 2: I think I've resolved this: Fabrice Bellard already agreed to relicense under a permissive license, see: https://github.com/mirror/tinycc/blob/mob/RELICENSING https://github.com/mirror/tinycc/blob/mob/RELICENSING Thus, I think it would be really hard to argue that there's any problem left, since the only file here that could be in violation (il-opcodes) is authored by fabrice bellard and arguably already permissively licensed. Case closed.
- throwaway2037 4y ago
  Authored by Fabrice Bellard: https://github.com/cheat-engine/cheat-engine/blob/master/Cheat%20Engine/tcclib/il-opcodes.h https://github.com/cheat-engine/cheat-engine/blob/master/Che... Says: * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. That looks like GPL 2+ to me. Please correct me if I misunderstand.
  - mytherin 4y ago
    Note the "(at your option) any later version" clause. The COPYING file contains this: * GNU LESSER GENERAL PUBLIC LICENSE * Version 2.1, February 1999 * [This is the first released version of the Lesser GPL. It also counts * as the successor of the GNU Library Public License, version 2, hence * the version number 2.1.] It seems to me that code is licensed under LGPL 2.1, as was mentioned by the cheat-engine author in the github issues. Edit: Fabrice Bellard is also the author of libtcc, who has chosen to release that project under LGPL, so this is irrelevant to begin with. The file is LGPL.
    - tedivm 4y ago
      The copying file was added years later and not by the same author as the original license. It looks like tcclib itself messed up somewhere along the lines here. Also, "any later version" is any later version of the same license. LGPL and GPL are two separate licenses- you can't switch GPL to LGPL using this clause.
    - toast0 4y ago
      GNU Library Public License (LPL?) != GNU General Public License (GPL)
      - klodolph 4y ago
        "Lesser General Public License" I assume that it used to stand for "library", and this was changed to discourage people from thinking of this library as the default license for libraries, and consider using the GPL instead. For example, the GNU Readline library is GPL, and this is reportedly the reason why CLISP is also GPL'd.
nightpool 4y ago
This comment only points out MPL or LGPL licensed code. tcclib contains a COPYING file that affirms all code distributed as part of tcclib is available under the LGPL. LuaSyntax.pas and SynHighlighterAA.pas are available under the MPL. The only actually GPL-licensed file in that list, obsolete_ntifs.h, doesn't exist in the repo. If you can find a version of CheatEngine that includes that file, presumably that would be a GPL violation, but that would have to rely on an analysis of how integrated the DBKKernel component is with the rest of the CheatEngine system.
- formerly_proven 4y ago
  obsolete_ntifs.h seems to only contain Windows API definitions, so it is doubtful that the GPL applies to using it (Oracle v. Google).