4 ms·
Was this change discussed publicly prior to merge? I think this is a big mistake. Build environments use separate users for security purposes. It's insane to d
by hda2 4y ago
Was this change discussed publicly prior to merge?
I think this is a big mistake. Build environments use separate users for security purposes. It's insane to decrease security for everyone by requiring a single user to do everything because some of your users want to have fancy terminal prompts.
At the very least, let users configure this at a per-user level.
- tylersmith 4y agoFixing RCE vulnerabilities isn't something that should be debated about publicly.
- hda2 4y agoNitpick: This isn't an RCE. An attacker would need 1) write access to a /local/ directory that the target will navigate to in his shell, and 2) convince the target to execute arbitrary git hooks in every directory (or parent directory) he visits by adding git to his shell's PS prompt. Besides, now that this security issue is patched, git devs should seek a proper solution to that doesn't break git and decrease security for everyone else.
- wonnage 4y agoThis isn't an RCE, you need to have control over the parent directory first which usually implies some sort of admin privileges already
- saagarjha 4y agoThis is just one way to fix the vulnerability. There are others, with different tradeoffs.
- deleted 4y ago[deleted]