5 ms·

Assuming you squash the PR and view it holistically, what's the issue?

• rubyist5eva 5y ago
  PRs dont' squashed, nothing gets rebased and only merge commits are allowed for anything non-local. It adds noise to trying to figure out why changes are made because the commit messages only explain what was changed, not the purpose or context.
  • SketchySeaBeast 5y ago
    If you're not squashing your PR's I can see the problem, but I also see the other problem.
    • maleldil 5y ago
      Do you think squashing the PR is the superior choice? Why?
      • SketchySeaBeast 5y ago
        Because then you don't see all those minor little changes and can view the PR holistically. I don't typically find that viewing the changes in chronologically order buys much, it's not the order I care about, it's the final changes themselves that have an impact on the system, especially when those changes could be transient (changing something in commit #1, change it back in commit #3). There's a larger load to comprehension with a squashed commit, but it shouldn't be THAT large, and it removes all the temporal noise. It also makes tracing the historical "why" of a change easier to understand. If you don't squash it's a random change in the log, if you do squash then it's "adding feature x".