5 ms·

>The recoloring functionality there would not be possible in GTK3. This isn't true though. https://github.com/Gnostiphage/adwaita-color-gen https://github.com/

>The recoloring functionality there would not be possible in GTK3. This isn't true though. https://github.com/Gnostiphage/adwaita-color-gen https://github.com/Gnostiphage/adwaita-color-gen

smoldesu 5y ago
On top of that, inline CSS has been a thing since... GTK2? I'm not sure what the parent is getting at here. Yes, they added a new way to do a thing. That alone does not an upgrade make.
- throwaway82652 5y ago
  No this post is again incorrect, GTK2 did not support CSS at all. And inline CSS has not been removed from GTK4 or libadwaita, you can still do that very easily. >Yes, they added a new way to do a thing. That alone does not an upgrade make. I'm confused as to what you think new features and upgrades are exactly, besides new ways to do things.
  - smoldesu 5y ago
    Fine then, GTK3 certainly has it, I know because I've used it myself. Pedantry aside, the point stands: it's not new, and it's certainly not functionality.
    - throwaway82652 5y ago
      >it's not new, and it's certainly not functionality. For GTK? Yes it is new and it is functionality, full recoloring of the theme was not previously supported. You can just look at the screenshots, the recoloring in the new text editor is an obvious improvement over the limited theme support that was in gedit. Maybe you don't want this functionality, and that's fine, but either of us can go open these apps up in a VM right now and compare them and note for a fact that the functionality has been added.
throwaway82652 5y ago
>This isn't true though Actually it is. That generator is only changing the equivalent of accent color. The libadwaita recoloring is the whole app. You will run into issues if you try to recolor everything in GTK3 that way. Yes you could technically rewrite the whole GTK3 stylesheet and recolor it that way, and lots of theme authors have done that, but at that point it's no different from what libadwaita does.
- smoldesu 5y ago
  > but at that point it's no different from what libadwaita does. So... we're just conceding that the feature you outlined isn't new, just a different way of getting an outcome that could already be achieved with older versions?
  - throwaway82652 5y ago
    >So... we're just conceding that the feature you outlined isn't new No, it could not be done in older versions unless you made all apps base their design around that stylesheet, which nobody actually did because it would break a lot of older apps. They didn't bother to do it until GTK4 because it requires changing the stylesheet anyway and apps have to actively migrate to it, so it's the perfect time to get this out of the way. If you're referring to individual apps, yes they could always technically implement their own theming system, just like they could always implement their own toolkit from scratch if they really wanted to. The point now is it's built into the platform and will actually have a shot at being usable in every app using libadwaita, not just ones that decide to ship a third party stylesheet because they decided they want to support ubuntu or budgie or something.
    - smoldesu 5y ago
      This isn't even an argument. GTK3 had custom CSS supported alongside custom stylesheets. I hate to be reductive, but you're making things up here. I have built applications like this with my own two hands, it's really nothing new.

>The recoloring functionality there would not be possible in GTK3. This isn't true though. https://github.com/Gnostiphage/adwaita-color-gen https://github.com/Gnostiphage/adwaita-color-gen

smoldesu 5y ago

On top of that, inline CSS has been a thing since... GTK2? I'm not sure what the parent is getting at here. Yes, they added a new way to do a thing. That alone does not an upgrade make.

throwaway82652 5y ago
No this post is again incorrect, GTK2 did not support CSS at all. And inline CSS has not been removed from GTK4 or libadwaita, you can still do that very easily. >Yes, they added a new way to do a thing. That alone does not an upgrade make. I'm confused as to what you think new features and upgrades are exactly, besides new ways to do things.
- smoldesu 5y ago
  Fine then, GTK3 certainly has it, I know because I've used it myself. Pedantry aside, the point stands: it's not new, and it's certainly not functionality.
  - throwaway82652 5y ago
    >it's not new, and it's certainly not functionality. For GTK? Yes it is new and it is functionality, full recoloring of the theme was not previously supported. You can just look at the screenshots, the recoloring in the new text editor is an obvious improvement over the limited theme support that was in gedit. Maybe you don't want this functionality, and that's fine, but either of us can go open these apps up in a VM right now and compare them and note for a fact that the functionality has been added.

throwaway82652 5y ago

>This isn't true though Actually it is. That generator is only changing the equivalent of accent color. The libadwaita recoloring is the whole app. You will run into issues if you try to recolor everything in GTK3 that way. Yes you could technically rewrite the whole GTK3 stylesheet and recolor it that way, and lots of theme authors have done that, but at that point it's no different from what libadwaita does.

smoldesu 5y ago
> but at that point it's no different from what libadwaita does. So... we're just conceding that the feature you outlined isn't new, just a different way of getting an outcome that could already be achieved with older versions?
- throwaway82652 5y ago
  >So... we're just conceding that the feature you outlined isn't new No, it could not be done in older versions unless you made all apps base their design around that stylesheet, which nobody actually did because it would break a lot of older apps. They didn't bother to do it until GTK4 because it requires changing the stylesheet anyway and apps have to actively migrate to it, so it's the perfect time to get this out of the way. If you're referring to individual apps, yes they could always technically implement their own theming system, just like they could always implement their own toolkit from scratch if they really wanted to. The point now is it's built into the platform and will actually have a shot at being usable in every app using libadwaita, not just ones that decide to ship a third party stylesheet because they decided they want to support ubuntu or budgie or something.
  - smoldesu 5y ago
    This isn't even an argument. GTK3 had custom CSS supported alongside custom stylesheets. I hate to be reductive, but you're making things up here. I have built applications like this with my own two hands, it's really nothing new.