3 ms·
This seems to be a minor bug, in that it is only triggered using unusual (and rather unlikely) deflate parameters. But, looking into this bug, I was sort-of in
by mdb31 5y ago
This seems to be a minor bug, in that it is only triggered using unusual (and rather unlikely) deflate parameters.
But, looking into this bug, I was sort-of interested to see how it was handled. The change log for 1.2.12 (2022-03-27) indicates the issue was resolved ("Fix a bug that can crash deflate on some input when using Z_FIXED"). Yet, in what seems to be the canonical Zlib repository (https://github.com/madler/zlib https://github.com/madler/zlib), I was unable to find a corresponding commit.
None of commits this year (7, so not too hard to review) seem to be particularity meaningful changes, and in particular yesterday's 'zlib 1.2.12' commit seems to only consist of version/copyright updates.
So, does anyone have any idea where to find the commits related to the change log entry? (Note that I'm not disputing the issue is actually fixed, I'm just trying to improve my Github reading skills...)
- kam 5y agoIt was fixed in 2018, but no release was made at the time https://github.com/madler/zlib/commit/5c44459c3b28a9bd3283aaceab7c615f8020c531 https://github.com/madler/zlib/commit/5c44459c3b28a9bd3283aa...
- mdb31 5y agoThank you very much! Sort-of surprising there is so much discussion about a long-fixed bug, yet, there we are...
- pajko 5y agoA lot of older projects (especially statically linked Windows applications) might contain an older release of zlib which is still affected by the bug. Don't know anything about the nature of the bug, but if the corruption could be converted to memory corruption... we have a problem.
- benibela 5y agoI wonder if FreePascal is affected Looks like they ported zlib to Pascal in 1998 and left it pretty much unchanged: https://gitlab.com/freepascal.org/fpc/source/-/blob/main/packages/paszlib/src/zdeflate.pas#L580 https://gitlab.com/freepascal.org/fpc/source/-/blob/main/pac...