3 ms·
what is more concerning is that the maintainer didn't understand this impact case, even when two people showed him the exact logic, linenumber and a reproducer.
by rurban 5y ago
what is more concerning is that the maintainer didn't understand this impact case, even when two people showed him the exact logic, linenumber and a reproducer. he was still the opinion that this cannot happen in production.
we need a zlib fork
- mkj 5y agomemLevel=1 afaik is pretty rare in the wild? The maintainer doesn't seem to dispute it after a reproducer was shown, a new release is out now.
- adzm 5y agodefault memLevel is 8. Memory usage is basically defined by windowBits and memLevel; 1 would be really unusual, even for embedded scenarios.
- plorkyeran 5y agoYeah, the existence of memLevel is basically a historical quirk. The total memory used by zlib at default memLevel and windowBits is under 300KB (it needs one 256KB buffer and a few small additional allocations). There's not a lot of environments left where it makes sense to run zlib where that's too much.
- rurban 5y agoI showed him the exact problematic line, but he didn't seem to understand it. same thing happened previously.
- jsnell 5y agoThere are already active zlib forks (e.g. https://github.com/zlib-ng/zlib-ng https://github.com/zlib-ng/zlib-ng), the problem is with having people move to them. It takes a lot of effort to move mindshare from the original version to a fork, there's some historical examples of it happening, but not a ton.
- rurban 5y agoah, thanks. this looks indeed as not from the last century. much better code.