3 ms·
If code is getting to the PR stage and doesn't compile, you have serious organizational problems. In previous jobs, I have "reviewed" code that has clearly nev
by icedchai 5y ago
If code is getting to the PR stage and doesn't compile, you have serious organizational problems.
In previous jobs, I have "reviewed" code that has clearly never been run (syntax error in a script) and it makes me question my own sanity.
- Quarrelsome 5y agoOr breaks the build in an otherwise non-obvious fashion or fucks the installer?
- icedchai 5y agoOne of the first things I check on a PR is if it passed CI cleanly. If the build has failed (failing tests, build problems, whatever), I get annoyed I was even asked to look at it.