4 ms·
If your team does not share a subjective understanding of what makes their product/API useful none of this matters. Focusing on objective technicalities is the
by pcmoney 5y ago
If your team does not share a subjective understanding of what makes their product/API useful none of this matters. Focusing on objective technicalities is the least useful aspect of code review. If you have someone who constantly is like "Well that's subjective" and derails conversation that way you need to coach them or move them off the team.
- mannykannot 5y agoAre you saying that if you enter a code review without having a shared subjective understanding of what makes your product/API useful then the review is not likely to be successful, or that code review is the place to form such a shared subjective understanding? I can agree to the first interpretation, but about the latter I would say that code review is quite a bit later than optimal, and that there are other, better ways of achieving it. If your organization is such that you cannot even discuss these issues until you have working code, then you have other, bigger, problems.
- pcmoney 5y agoThe former, ideally the subjective understanding should be shared before the story/ticket is written and definitely before it is started. Code review is way too late.