3 ms·
As a counter argument, it's much easier for a developer to write code that does the right thing when that code is readable. Too often I see code that is _maybe
by mdtusz 5y ago
As a counter argument, it's much easier for a developer to write code that does the right thing when that code is readable.
Too often I see code that is _maybe_ correct, but the reviewer can't actually be sure of it without manually testing it, and the chances that a future reader in 4 months will have any idea what it does or why are extremely low. Good variable and function names get you 90% of the way there yet for some reason cryptic code is still all too common in the world.
To me, reviewing for readability isn't nitpicking - it's equivalent to a mechanical engineering design review pointing out that design for maintenance or design for assembly has been entirely ignored.