3 ms·
Yikes, do all filters do that? https://github.com/higgins/privatize/blob/0.1.1/index.js#L98 https://github.com/higgins/privatize/blob/0.1.1/index.js#L98 Also,
by mdaniel 5y ago
Yikes, do all filters do that? https://github.com/higgins/privatize/blob/0.1.1/index.js#L98 https://github.com/higgins/privatize/blob/0.1.1/index.js#L98
Also, it's 2022 and I still have to remind people not to commit binary assets into git repos, as the repo will grow without bound: https://github.com/higgins/privatize/tree/main/release https://github.com/higgins/privatize/tree/main/release
That's the very problem that GitHub Releases were designed to address, and has the extra awesome benefit of using (currently) AWS S3 for distribution, which is almost certainly going to be faster and place less load upon github.com than .../raw/main/release/whatever.exe
Also, while the Brew tap indicates your code is ISC, there is no license file in your repo: https://github.com/higgins/homebrew-privatize/blob/main/Formula/privatize.rb#L8 https://github.com/higgins/homebrew-privatize/blob/main/Form...
- deleted 5y ago[deleted]
- higgins 5y agoThanks for your thorough feedback! Much appreciated Added some more TODOs to address your comments. :) FWIW, the `git reset --hard` is only on unlocking a repo that was previously privatize'd. Still, not a great FTUX. Will update.