3 ms·
While true, it's important to ensure there is adequate test coverage before trying to refactor, in case you miss something. Also, try to avoid small commits /
by Cthulhu_ 5y ago
While true, it's important to ensure there is adequate test coverage before trying to refactor, in case you miss something.
Also, try to avoid small commits / changes; churn in code should be avoided, especially in kernel code. IIRC the Linux project and a lot of open source projects do not accept 'refactoring' pull requests, among other things for this exact reason.
- max_k 5y agoAgree, but even 100% test coverage can't catch this kind of bug. I don't know of any systematic testing method which would be able to catch it. Maybe something like valgrind which detects accesses to uninitialized memory, but then you'd still have to execute very special code paths (which is "more" than 100% coverage).
- aaronmdjones 5y agoValgrind cannot be used for/in the kernel. However, the kernel has an almost-equivalent use-of-uninitialized-memory detector; https://www.kernel.org/doc/html/v4.14/dev-tools/kmemcheck.html https://www.kernel.org/doc/html/v4.14/dev-tools/kmemcheck.ht...
- cwilkes 5y ago> try to avoid small commits / changes Not sure what you mean by that