4 ms·
Code review != Testing. A lot of people conflate these IMHO. Code review should not really be about whether it "works" or not. That's what tests are for. Code
by bradwood 5y ago
Code review != Testing.
A lot of people conflate these IMHO. Code review should not really be about whether it "works" or not. That's what tests are for.
Code reviews are about checking for code complexity, good use of abstractions, readability, etc.
- magusd 5y agothis should be the most upvoted comment
- presentation 5y agoAnd also to spread knowledge of aspects of the system across the team.
- epolanski 5y agoYou have to review tests and you are back at square one.
- websap 5y agoWhat's the point of checking for those if the bar for fully functional isn't met?
- bradwood 5y agoNone. So don't do the review until CI passes.