4 ms·
Or have a machine run the code, like a CI system?
by verdverm 5y ago
Or have a machine run the code, like a CI system?
- icedchai 5y agoOften, it is not that simple. Many code bases are completely lacking any integration or end-to-end tests, despite having tons of unit tests. Unit tests can pass, but the system may still "not work" due to failures to call the new code in the correct place. The original developer can miss this and it may not be obvious from the context of the PR that something not already in the PR needs to also change. "You don't know what you don't know..."
- verdverm 5y agoIt seems to me it would be worth the effort to get CI in place over having reviewers manually run the same thing. The labor is more expensive than the computers
- icedchai 5y agoYes. Ideally we would write integration and e2e tests, and run them during CI. I personally favor those sorts of tests but they require a lot of effort.
- makapuf 5y agoReview should ensure there are tests, and that those tests run on ci and my laptop. When tests are difficult or not worth it (sometimes ui or end to end) I think to be sufficiently confident reviewer shall run the code. Its possible to do without but that's technical debt