3 ms·
I don’t get your first point. If the pull request doesn’t run: - how can we even say it works? - who’s responsibility is it to fix it? - and when does it get
by wodenokoto 5y ago
I don’t get your first point. If the pull request doesn’t run:
- how can we even say it works?
- who’s responsibility is it to fix it?
- and when does it get fixed?
- c7DJTLrn 5y agoWhat do you mean "doesn't run"? Tests should catch the most obvious/common bugs. If you mean it doesn't compile, then something is wrong because why would any engineer check in code that doesn't compile unless they're distracted or under pressure? And again, this would be caught by CI.
- striking 5y agoIn order: * Tests * The engineer making the PR * Before they're allowed to merge