4 ms·
Theoretically it means that if someone has your password and has MITM'd you or has a keylogger on you, they can log in as you in the 30 second window. That sai
by lolinder 5y ago
Theoretically it means that if someone has your password and has MITM'd you or has a keylogger on you, they can log in as you in the 30 second window.
That said, someone with the level of access required to exploit this vulnerability isn't going to be stopped because GitLab patches it. There are plenty of other things they could do with that kind of access.
- hn_throwaway_99 5y agoThis is why threat vector analysis is so important, because in your case, there is no additional vector. If someone has MITM'd you, they can just intercept your token before they pass it to Gitlab. And to your other point, you're right, if your adversary already has a keylogger running on your device you're pretty much screwed in any case.
- nijave 5y agoIt enables phishing where you're actually logged in after submitting your credentials. You don't need a MITM from a network perspective.
- hedora 5y agoSeparately, if the attacker has the password and a mitm for the totp code, then this allows them to logg in without being detected.