4 ms·

Good stuff in here. But since they found a bug which caused them to disable incremental compilation by default for this release, I'll likely skip this one and w

Good stuff in here. But since they found a bug which caused them to disable incremental compilation by default for this release, I'll likely skip this one and wait a few weeks for 1.60.0 (which these release notes state will likely address the problem and restore default incremental compilation)

DougBTX 5y ago
Have to say I’ve not been following this in any detail, but it was also disabled in 1.52.1, has it been re-enabled again in the meantime? https://blog.rust-lang.org/2021/05/10/Rust-1.52.1.html https://blog.rust-lang.org/2021/05/10/Rust-1.52.1.html
- nicoburns 5y ago
  Yes, it had. There have been ongoing minor bugs (most people won't hit them, and if they do they can just do a fresh build) which they've been fixing over time. But apparently some of the fixes exposed a worse bug this time around, and it wasn't caught until just before the release.
  - estebank 5y ago
    Part of the reason they weren't caught is because it got fixed on nightly right after the previous beta cut off. If the same bug had been present on nightly it would have been picked up quickly.
kibwen 5y ago
Alternatively you can use Rust beta today: `rustup toolchain install beta && rustup default beta`. You'll be doing everyone a favor, as the fact that relatively few people use beta regularly is part of the reason that this issue didn't surface until the last minute. (Plenty of people use beta for CI, which is great, but CI obviously doesn't exercise incremental compilation).
black_puppydog 5y ago
Errrrr.... so you mean you'd rather have the bug, thank you very much? :) Why not just "export RUSTC_FORCE_INCREMENTAL=1" in your env and hope for the best then? :P
- estebank 5y ago
  The bug is not present in the current beta or nightly. Waiting for 1.60 or using beta are reasonable things to do.
xiphias2 5y ago
Isn’t the best solution to stop the release in that case, and wait until the bug is fixed? It sends a signal to everybody that language correctness takes precedence over this extremely important feature that more developers depend on than the new features in the release, instead of treating the two with the same seriousness.
- pornel 5y ago
  Correctness takes precedence, which is why the incorrect code has been disabled, and even the full fix is going to go through a whole 6-week beta/release cycle instead of being expedited.
- kibwen 5y ago
  It would have to be quite a severe bug in order to justify delaying the release, which IMO was not warranted in this case. AFAICT, the effect of this bug is just that some users cannot compile their code without either clearing out their incremental compilation cache or disabling incremental compilation altogether. If it were truly severe, then they could have also disabled incremental compilation completely; right now it's only off by default.

DougBTX 5y ago

Have to say I’ve not been following this in any detail, but it was also disabled in 1.52.1, has it been re-enabled again in the meantime? https://blog.rust-lang.org/2021/05/10/Rust-1.52.1.html https://blog.rust-lang.org/2021/05/10/Rust-1.52.1.html

nicoburns 5y ago
Yes, it had. There have been ongoing minor bugs (most people won't hit them, and if they do they can just do a fresh build) which they've been fixing over time. But apparently some of the fixes exposed a worse bug this time around, and it wasn't caught until just before the release.
- estebank 5y ago
  Part of the reason they weren't caught is because it got fixed on nightly right after the previous beta cut off. If the same bug had been present on nightly it would have been picked up quickly.

kibwen 5y ago

Alternatively you can use Rust beta today: `rustup toolchain install beta && rustup default beta`. You'll be doing everyone a favor, as the fact that relatively few people use beta regularly is part of the reason that this issue didn't surface until the last minute. (Plenty of people use beta for CI, which is great, but CI obviously doesn't exercise incremental compilation).

black_puppydog 5y ago

Errrrr.... so you mean you'd rather have the bug, thank you very much? :) Why not just "export RUSTC_FORCE_INCREMENTAL=1" in your env and hope for the best then? :P

estebank 5y ago
The bug is not present in the current beta or nightly. Waiting for 1.60 or using beta are reasonable things to do.

xiphias2 5y ago

Isn’t the best solution to stop the release in that case, and wait until the bug is fixed? It sends a signal to everybody that language correctness takes precedence over this extremely important feature that more developers depend on than the new features in the release, instead of treating the two with the same seriousness.

pornel 5y ago
Correctness takes precedence, which is why the incorrect code has been disabled, and even the full fix is going to go through a whole 6-week beta/release cycle instead of being expedited.
kibwen 5y ago
It would have to be quite a severe bug in order to justify delaying the release, which IMO was not warranted in this case. AFAICT, the effect of this bug is just that some users cannot compile their code without either clearing out their incremental compilation cache or disabling incremental compilation altogether. If it were truly severe, then they could have also disabled incremental compilation completely; right now it's only off by default.