3 ms·
Thanks for your comment. I amended my second paragraph to try to make my point clearer. I am in no way advocating for in-person code review. I’m saying that
by gorgoiler 5y ago
Thanks for your comment. I amended my second paragraph to try to make my point clearer.
I am in no way advocating for in-person code review. I’m saying that it’s much harder to do code review with someone you haven’t shared lunch with, chatted with in the pub, or had a non-work related phone call with for 9 months.
Your point about public GitHub is pretty much on point. Some of the least productive and most barbed back-and-forth you see on code reviews is the public FOSS ones where people don’t really know or trust each other that much.
Some of the best are where the reviewers clearly want to work together on something and not be confrontational.
(By the way: I don’t see this behaviour as openly confrontational in terms of deliberate aggression — more commonly it’s a reviewer subconsciously expressing their self-perceived lack of standing by criticising other’s work.)