12 ms·
On the other hand, someone coming after you might read the code in the same order and have the same wtf moment. They may even never find that later piece you sa
by spockz 5y ago
On the other hand, someone coming after you might read the code in the same order and have the same wtf moment. They may even never find that later piece you saw in the review. So at the least it should still be a signal to the Author that it appears strange.
- funkymike 5y agoI also really like this feature of GitHub reviews and when deleting a comment as I continue reading I try to question whether to add a code comment so the next person doesn't get tripped up because they don't have the full context in their head.