4 ms·
> they've probably spent a really long time working on the actual content of the email and haven't had the opportunity to step back and consider Before you ask
by shkkmo 5y ago
> they've probably spent a really long time working on the actual content of the email and haven't had the opportunity to step back and consider
Before you ask someone to proof read anything, you should generally take the effort to step back and try to proof read it yourself. The same goes with code reviews.
I think there is absolutely value in soliciting feedback throughout the process, but would consider those earlier feedback stagea to be design and/or implementation reviews (which depending on feature size should happen with varying degrees of formality.) It is useful to be explicit about the types of review because the types feedback that are useful vary throughout the process. If you are looking for design feedback and someone complains about unimplemented tests, that generally isn't very helpful. If you are looking for a final code review for polished code and you get feedback about the underlying design, then you really needed to get that feedback earlier in the process.