2 ms·
Imo, the code review is not the place to over communicate your preferences. Do it on developers meeting. Do it in a chat. Do it on standup. Don't do it in rando
by watwut 5y ago
Imo, the code review is not the place to over communicate your preferences. Do it on developers meeting. Do it in a chat. Do it on standup. Don't do it in random code reviews where people unlucky enough to get you as reviewer have to deal with different expectations then anybody else and spend hours discussing your personal preferences - without any real impact on general codebase because other reviewers and coders have different preferences.
- sesuximo 5y agoMaybe preference was the wrong word for me to use. “Reasoning” might make more sense? If comments don’t impact the code base or the people involved, then yeah they’re not useful.