4 ms·
I agree it can introduce bugs, my point is relying on that is probably a design issue somewhere else. Because even in the first, you are relying on the order o
by rileymat2 5y ago
I agree it can introduce bugs, my point is relying on that is probably a design issue somewhere else.
Because even in the first, you are relying on the order of max being the same everywhere it matters.
- withinboredom 5y agoMaybe. If it’s usage were in the scope of the current PR, I might suggest a fix like this. But if it might introduce something subtle, I probably wouldn’t suggest it or I’d ask if they had considered changing it as well as if there were any subtle issues to worry about. As someone who works in a multimillion line codebase that sees millions of executions daily since 2005, these are real issues and saying “it’s a design issue somewhere else” doesn’t exactly fly because that “somewhere else” may no longer have a team maintaining it.