3 ms·
I'm conflicted on this. On one hand, I think it makes sense to over-communicate preferences because building consensus on these things is hard without it. On th
by Conan_Kudo 5y ago
I'm conflicted on this. On one hand, I think it makes sense to over-communicate preferences because building consensus on these things is hard without it. On the other hand, I don't like how it causes everything to drag out...
Maybe it's worth trading off on going one way or another? Or maybe there's a happy medium somewhere...
- cube2222 5y agoA nice practice is to finish all such nitpicky comments with the strength of your opinion / how much you care. This way, if most of those are "very little" then it's up to the author to decide whether to do it or not, and they don't have to wait for you to circle back about it.
- LukeShu 5y agoThe happy medium I've found is to clarify my level of preference; whether it's a "nitpick" or an actual "change request". I communicate that you don't have to update the PR just for nitpicks, but that if you're updating it anyway that they might be good things to also change.