2 ms·
The last time I offered a Rails PR that extended core classes, it got a thumbs down review on that basis alone. Solnic's complaint is often voiced, and has mer
by inopinatus 5y ago
The last time I offered a Rails PR that extended core classes, it got a thumbs down review on that basis alone.
Solnic's complaint is often voiced, and has merit for all the reasons given (and more besides IMO), and Rails is certainly stuck with ActiveSupport, but the core team does not seem keen on exacerbating the problem.
Additions to ext modules are, consequently, rare, and in fact there's a trend going the other way, e.g. https://github.com/rails/rails/commit/33ca3923170a50da7f173165f7b8ba20fcd32803 https://github.com/rails/rails/commit/33ca3923170a50da7f1731...