3 ms·
Those wasm blobs are Node's own llhttp https://github.com/nodejs/llhttp https://github.com/nodejs/llhttp in wasm to speed up HTTP parsing. The project itself ad
by inglor 5y ago
Those wasm blobs are Node's own llhttp https://github.com/nodejs/llhttp https://github.com/nodejs/llhttp in wasm to speed up HTTP parsing. The project itself added as a dependency is also by Node https://github.com/nodejs/undici https://github.com/nodejs/undici .
The question is totally legitimate but please assume core doesn't make "load random binary" level kind of goofs :)
- franciscop 5y agoSorry def didn't mean in a bad way! I just wanted to ask/note that in the PR, and with the very little context I have, it seems like an arbitrary code blob so I was surprised, I'm 100% it'll be well documented in e.g. undici itself, and prob in other places.
- krono 5y agoExcept that's exactly what Corepack does, just silently and opaquely on the user's system. At least, the moment it switches from opt-in to opt-out. Its unverified binaries are just as good as random binaries, and silently replacing any pre-existing yarn/pnpm/whathaveyou without checking if it was perhaps a custom build is not exactly predictable either. Other than Corepack, though, I think you people are doing an amazing job!