3 ms·

As far as I recall, VSCode had to fork electron in order to make it acceptably performant. The team tried to use stock electron but the performance was not good

by eyegor 5y ago

As far as I recall, VSCode had to fork electron in order to make it acceptably performant. The team tried to use stock electron but the performance was not good. And they're probably going to move to because electron is still slow and terrible. https://github.com/microsoft/vscode/issues/118308 https://github.com/microsoft/vscode/issues/118308

pizza234 5y ago
> The team tried to use stock electron but the performance was not good. Can you provide references of this fork? It you actually look at the VSC manifest, you'll find that the vanilla "electron" is a dependency. > And they're probably going to move to because electron is still slow and terrible. I take you haven't used Visual Studio Code. As I wrote, it's certainly not the fastest editor, but it's fast enough for professional usage. It's actually faster (or comparable at least) to other "famous editors". > https://github.com/microsoft/vscode/issues/118308 https://github.com/microsoft/vscode/issues/118308 This doesn't have any actual technical content; it's essentially a variation of Rewrite It In Rust.
- cassianoleal 5y ago
  Much lower memory consumption and startup time cut down to ~50% sound like technical enough reasons to me.
- eyegor 5y ago
  So I know that currently they use electron, but I vaguely recall them working on a fork of electron to replace chromium etc. across all their products (edge, code, others?). I can't seem to find public references to it related to code, it might have been discussed more in regards to the edgehtml/chakra implementation. I may also be mixing things up, that was around 2015 I think.
marwis 5y ago
Untruths. https://github.com/microsoft/vscode/blob/main/package.json https://github.com/microsoft/vscode/blob/main/package.json -> "electron": "13.5.1", Referenced github issue seems to have only random people unaffiliated with the project team.
- eyegor 5y ago
  Yes I'm aware that they currently use stock electron, I was referring to earlier development. Maybe like 2015 or so. Could be mistaken, I'm not sure that work was ever published.

by eyegor 5y ago

pizza234 5y ago

> The team tried to use stock electron but the performance was not good. Can you provide references of this fork? It you actually look at the VSC manifest, you'll find that the vanilla "electron" is a dependency. > And they're probably going to move to because electron is still slow and terrible. I take you haven't used Visual Studio Code. As I wrote, it's certainly not the fastest editor, but it's fast enough for professional usage. It's actually faster (or comparable at least) to other "famous editors". > https://github.com/microsoft/vscode/issues/118308 https://github.com/microsoft/vscode/issues/118308 This doesn't have any actual technical content; it's essentially a variation of Rewrite It In Rust.

cassianoleal 5y ago
Much lower memory consumption and startup time cut down to ~50% sound like technical enough reasons to me.
eyegor 5y ago
So I know that currently they use electron, but I vaguely recall them working on a fork of electron to replace chromium etc. across all their products (edge, code, others?). I can't seem to find public references to it related to code, it might have been discussed more in regards to the edgehtml/chakra implementation. I may also be mixing things up, that was around 2015 I think.

marwis 5y ago

Untruths. https://github.com/microsoft/vscode/blob/main/package.json https://github.com/microsoft/vscode/blob/main/package.json -> "electron": "13.5.1", Referenced github issue seems to have only random people unaffiliated with the project team.

eyegor 5y ago
Yes I'm aware that they currently use stock electron, I was referring to earlier development. Maybe like 2015 or so. Could be mistaken, I'm not sure that work was ever published.