13 ms·
Agreed, it's a matter of preference, but I prefer logically separate changes to be in separate commits at least within the PR, where it may make reviewing the P
by pferde 5y ago
Agreed, it's a matter of preference, but I prefer logically separate changes to be in separate commits at least within the PR, where it may make reviewing the PR easier. It's basic empathy towards the reviewer(s).
Of course, when merged, it often makes sense to squash some commits together, just like you say - long-term, many of the feature development details are not important.
It's not an either-or proposition.