3 ms·
I once joined a new company and got stuck in the middle of a PR from hell. What should have been a quick bug fix (maybe 10 lines of code), turned into weeks an
by stack_framer 5y ago
I once joined a new company and got stuck in the middle of a PR from hell.
What should have been a quick bug fix (maybe 10 lines of code), turned into weeks and weeks of being told to rename, reorganize, and restructure aspects of the fix and surrounding code in order to adhere to a variety of undocumented conventions.
Despite following patterns used elsewhere in the very same files, my code was deemed brittle, confusing, and poorly tested (we don't do this, we're trying not to do that).
I patiently addressed each item of feedback, but of the dozens and dozens of PR comments, not one was ever about the accuracy of the logic that fixed the bug.
Welcome aboard!