2 ms·
> ... Code review should be a chance for teams to learn from each other, catch issues, and align on coding practices and strategies. IMO a practical benefit of
by zoomablemind 5y ago
> ... Code review should be a chance for teams to learn from each other, catch issues, and align on coding practices and strategies.
IMO a practical benefit of a routine code review is just a shared understanding. As simple as that. Does the code look to be doing what it says it should do? Do the tests express the intended behavior?
Of course, the style, the quality of code could be of attention too, but that's extras, in my opinion, as long as the functionality is understood and confirmed.
I like relating this to an effort of understanding someone who speaks with an accent, be it a local dialect or foreign-originated. It does require some tolerance, but the shared understanding is the goal.