3 ms·

In my 5th role where I write code, and I have dealt with so many different approaches and definitions of "best practice" that at this point I just roll over to

In my 5th role where I write code, and I have dealt with so many different approaches and definitions of "best practice" that at this point I just roll over to whatever the generally agreed approach is at my current org and mimic it as best as possible. In one organization, I have even had two seniors go back and forth telling me to remove what the other senior told me to put in. The entire process of defining "clean code" seems painfully arbitrary.

CRConrad 5y ago
> In one organization, I have even had two seniors go back and forth telling me to remove what the other senior told me to put in. From: You To: Senior1, Senior2, Senior1s_Manager, Senior2s_Manager, Your_Manager Subject: Duke it out between yourselves Senior1, you told me to put in Feature1, Feature2, and Feature3. A while later, Senior2 told me to take them out. Senior2, you told me to put in Feature4, Feature5, and Feature6. A while later, Senior1 told me to take them out. My job is to implement worthwhile features, not to be an implement in your quarrel over which features are worthwhile to implement. Duke that out between yourselves, and only then give me the ones you can agree on to implement. Thank you. Your_Manager, I've looked over my job description. It says my job is to implement worthwhile features, not to be an implement in other people's quarrels. Yours says your job is to back me up in situations like this. Senior1s_Manager and Senior2s_Manager, maybe Senior1's and Senior2's job descriptions need to be clarified with regards to which features each of them is empowered to request or veto.
musingsole 5y ago
Similarly, the existence of so many subjective and unarticulated views on "code correctness" has left me in a place where the only certainty is: there is no certainty. If your best practices are so great, make a sound business case for them. Uncle Bob did no such thing.
cardinalfang 5y ago
That can probably be automated. clang-tidy has some opinionated linting rules that contradict each other, just enabled these and choose to auto-fix.
- MattGaiser 5y ago
  Oh, if only people agreed on the automation. Those two seniors used different preferred linters as well.

CRConrad 5y ago

> In one organization, I have even had two seniors go back and forth telling me to remove what the other senior told me to put in. From: You To: Senior1, Senior2, Senior1s_Manager, Senior2s_Manager, Your_Manager Subject: Duke it out between yourselves Senior1, you told me to put in Feature1, Feature2, and Feature3. A while later, Senior2 told me to take them out. Senior2, you told me to put in Feature4, Feature5, and Feature6. A while later, Senior1 told me to take them out. My job is to implement worthwhile features, not to be an implement in your quarrel over which features are worthwhile to implement. Duke that out between yourselves, and only then give me the ones you can agree on to implement. Thank you. Your_Manager, I've looked over my job description. It says my job is to implement worthwhile features, not to be an implement in other people's quarrels. Yours says your job is to back me up in situations like this. Senior1s_Manager and Senior2s_Manager, maybe Senior1's and Senior2's job descriptions need to be clarified with regards to which features each of them is empowered to request or veto.

musingsole 5y ago

Similarly, the existence of so many subjective and unarticulated views on "code correctness" has left me in a place where the only certainty is: there is no certainty. If your best practices are so great, make a sound business case for them. Uncle Bob did no such thing.

cardinalfang 5y ago

That can probably be automated. clang-tidy has some opinionated linting rules that contradict each other, just enabled these and choose to auto-fix.

MattGaiser 5y ago
Oh, if only people agreed on the automation. Those two seniors used different preferred linters as well.