4 ms·
Could you please elaborate on the value you find in commits from other people that are along the lines of "more tests" or "first sketch", as opposed to crafting
by shandor 5y ago
Could you please elaborate on the value you find in commits from other people that are along the lines of "more tests" or "first sketch", as opposed to crafting a coherent single commit with a thoughtful commit message?
I'm honestly asking in good faith, as the commits you gave as an example are literal anathema to me, and I'd like to understand what value anyone can see in them.
- skinkestek 5y agoThe one I value is the "performance optimizations" and the last one. Problem is if we let squash zealots have their way they are gone together with the rest. Storage is cheap. You'll never ever be bothered by those commits unless you are bisecting and at that point you are probably thankful of you can find a commit message along the lines of: - performance optimizations - workaround for weird problem foo problem in prod as they will tell you a lot about how to approach it. Edit: Just having tests and modification because of tests added in their own commit and with a comment ("Also includes modifications to xyz to simplify testing." above) is useful. I do look into commits on a weekly basis or more to figure out why stuff was moved / replaced. Just yesterday I stopped a PR because a constant was changed in an unrelated commit as part of the larger PR. Because commits are granular it was really easy to see that it wasn't intended.