3 ms·
Surely the right answer would be something to the effect of "If this code survived in the source base until deployment, all is lost anyway." The point of code
by ajross 15y ago
Surely the right answer would be something to the effect of "If this code survived in the source base until deployment, all is lost anyway."
The point of code review is to catch monsters like this when they are written. If that doesn't happen, what's the point?
- Tyrannosaurs 15y agoThat's a very purist view of the world. This code works and, as he says, was produced by a coder under time pressure. You show me a system and pretty much I'll show you a system that has poor (but working) code in it produced by a competent developer under pressure. And code review is a useful process but it's no guarantee that issues will be caught any more than system testing or user acceptance testing. And yet the world keeps on spinning and all is not lost. I agree, you'd hope this was caught, but if someone gave that answer in an interview even aside from the tone, I'd wonder how much real world experience they had.