5 ms·
If someone gives you a PR that is a small, minimal change, and is backwards compatible, but fixing a load of issues because someone wants to improve their syste
by drekipus 5y ago
If someone gives you a PR that is a small, minimal change, and is backwards compatible, but fixing a load of issues because someone wants to improve their system and is often being used in tandem with yours... then you're kinda just being a troll.
Anything being used by other people will of course have changes. Software is never static unless you keep it to yourself in a locked basement.
This whole ordeal is sort of like having arguments with the wife and proving your point all the way to the divorce court, instead of just nodding, shrugging the shoulders, and getting on with life.
- reikonomusha 5y agoOn the other hand, if a single, foundational project is continually issuing PRs across the ecosystem that, at the end of the day, are not a result of changes that seem to benefit the user tangibly, then I could see it getting annoying for project maintainers.
- Arcsech 5y ago“Continually” is a pretty strong word for one change.
- reikonomusha 5y agoWhat's not obvious from the discussion here and elsewhere is that this was not the only change coming from ASDF to this same maintainer. The maintainer in question is also an SBCL developer, who is responsible for upgrading and shipping copies of ASDF with that implementation of Lisp. So it wasn't his first rodeo dealing with ASDF changing behavior (and, sometimes, breaking his users' code downstream). Finally, this wasn't one change to one project; this was one flavor of change that was being sent to the whole "edicl" collection of projects.