3 ms·

How can I refactor a monolithic codebase when every change breaks everything?

by muzani 5y ago

kevinmhickey 5y ago
Very carefully. But seriously, check out the book "Working Effectively With Legacy Code" by Feathers. It has helped me tremendously in multiple refactorings. His thesis is that Legacy Code is code without tests. So to make it not Legacy you need to add tests then refactor safely. Then he explains the very complex patterns that can arise and how to deal with them. This book is one of a few that changed my career. https://www.amazon.com/Working-Effectively-Legacy-Michael-Feathers/dp/0131177052/ref=sr_1_1?keywords=working+effectively+with+legacy+code&qid=1642561693&sprefix=working+effe%2Caps%2C95&sr=8-1 https://www.amazon.com/Working-Effectively-Legacy-Michael-Fe...
- muzani 5y ago
  Thanks for the recommendation! Exactly what I was looking for. Yup, the problem is that large chunks of the code are useless and must be removed, but I don't really want to write tests on those. Other parts have to be decoupled and removed and I end up needing to write end to end tests.
bobblywobbles 5y ago
Great idea! I really like it, I have worked in a few places where that happened as well. Can we collaborate a little bit more on what specific you are looking for - my contact details are on my blog (link is in my profile). Hope to hear back from you.
navyad 5y ago
First write tests without touching existing code. Once tests are complete, do refactor.
- muzani 5y ago
  For context, it's Android, and it'd doing weird threading stuff that makes tests crash.
hackerfromthefu 5y ago
First, getting this right without unplanned downtime can be hard to achieve and as well as lots of diligence it also really requires the right level of general application architecture plus hands on engineering experience. The general process is assessment and understanding the system, refactoring and improving code without program changes, and re-achitecting key pieces to enable the testing, then getting test coverage to where it gives you the required confidence to make the change.

How can I refactor a monolithic codebase when every change breaks everything?

by muzani 5y ago

How can I refactor a monolithic codebase when every change breaks everything?

Very carefully. But seriously, check out the book "Working Effectively With Legacy Code" by Feathers. It has helped me tremendously in multiple refactorings. His thesis is that Legacy Code is code without tests. So to make it not Legacy you need to add tests then refactor safely. Then he explains the very complex patterns that can arise and how to deal with them. This book is one of a few that changed my career. https://www.amazon.com/Working-Effectively-Legacy-Michael-Feathers/dp/0131177052/ref=sr_1_1?keywords=working+effectively+with+legacy+code&qid=1642561693&sprefix=working+effe%2Caps%2C95&sr=8-1 https://www.amazon.com/Working-Effectively-Legacy-Michael-Fe...

muzani 5y ago
Thanks for the recommendation! Exactly what I was looking for. Yup, the problem is that large chunks of the code are useless and must be removed, but I don't really want to write tests on those. Other parts have to be decoupled and removed and I end up needing to write end to end tests.

bobblywobbles 5y ago

Great idea! I really like it, I have worked in a few places where that happened as well. Can we collaborate a little bit more on what specific you are looking for - my contact details are on my blog (link is in my profile). Hope to hear back from you.

navyad 5y ago

First write tests without touching existing code. Once tests are complete, do refactor.

muzani 5y ago
For context, it's Android, and it'd doing weird threading stuff that makes tests crash.

hackerfromthefu 5y ago

First, getting this right without unplanned downtime can be hard to achieve and as well as lots of diligence it also really requires the right level of general application architecture plus hands on engineering experience. The general process is assessment and understanding the system, refactoring and improving code without program changes, and re-achitecting key pieces to enable the testing, then getting test coverage to where it gives you the required confidence to make the change.