2 ms·
The problems I see here are: 1. The parameter was named accessSecret, but the environment variable was (...)ACESS_TOKEN_SECRET. This type of inconsistency can
by PufPufPuf 5y ago
The problems I see here are:
1. The parameter was named accessSecret, but the environment variable was (...)ACESS_TOKEN_SECRET. This type of inconsistency can easily confuse a human programmer as well.
2. The programming language (JS) allowed an extraneous parameter to be included. Languages with stronger typing would at least allow the IDE to mark the parameter as unused/invalid.
3. The library didn't complain about a missing important parameter.