3 ms·
I like this advice. Especially that we want to block problems as late as possible, whilst warning as early as possible (e.g. warning in an IDE, blocking with a
by chriswarbo 5y ago
I like this advice. Especially that we want to block problems as late as possible, whilst warning as early as possible (e.g. warning in an IDE, blocking with a commit hook).
I also agree with the linting approach, and do the same myself:
- Automatically enable as many high-confidence checks as we can (if we want low-confidence 'suggestions', they can be run manually)
- Make them block (eventually, e.g. via a commit hook or a failing test)
- Allow '# disable-foo' annotations (with accompanying comment) when needed (with code review judging whether it's an appropriate solution or not, just like anything else)
- dllthomas 5y ago> blocking with a commit hook Commit hook is too early, at least on a development branch. I want to be able to preserve things with commentary without making sure they work at all, much less making sure they're lint free.