4 ms·

> On macOS, command-clicking links in Gmail now opens them in a new tab as expected. How is this Firefox's problem? Isn't Gmail just a website?

SwiftyBug 5y ago
That called my attention too. Does that mean Firefox runs code specifically on Gmail?
- wlpu 5y ago
  Does Chrome?
- coldpie 5y ago
  I found this link from another bug that was marked fixed in 96. It contains all bugs marked to be included in the changelog for 96: https://bugzilla.mozilla.org/buglist.cgi?f1=cf_tracking_firefox_relnote&o1=equals&v1=96%2B https://bugzilla.mozilla.org/buglist.cgi?f1=cf_tracking_fire... From there I found this bug relating to cmd-clicking links in Gmail: https://bugzilla.mozilla.org/show_bug.cgi?id=1739929 https://bugzilla.mozilla.org/show_bug.cgi?id=1739929 You can find detailed discussion about what's going on there. I believe this is the ultimate fix: https://hg.mozilla.org/mozilla-central/rev/0fb0990124cf https://hg.mozilla.org/mozilla-central/rev/0fb0990124cf It does not appear to be specific to Gmail, no.
  - hajhatten 5y ago
    Great find. I would've worded this differently then.
    - coldpie 5y ago
      Changelogs are really hard! Do you describe the actual bug that was fixed ("mouse click events in secure contexts would sometimes be ignored even if the web application didn't handle them") or do you describe the end-user impact ("middle-clicking links in gmail works again")? There's no right answer.
- frankjr 5y ago
  As others have pointed out, not in this case but in general yes - browsers do have website specific fixes for compatibility. Firefox: https://github.com/mozilla/gecko-dev/blob/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/browser/extensions/webcompat/data/injections.js https://github.com/mozilla/gecko-dev/blob/d107bc8aeadcc816ba... Safari: https://github.com/WebKit/WebKit/blob/86143cf226f227bac5ffad2dbcf1c0df64cbc69f/Source/WebCore/page/Quirks.cpp https://github.com/WebKit/WebKit/blob/86143cf226f227bac5ffad... I'm not sure what's the file for Chromium but I bet there's something similar.
  - marcthe12 5y ago
    I know there is quirks file for webkit which is used to be safari and webkit was forked to blink which runs chromium so it depend if its still there.
Isthatablackgsd 5y ago
I loaded up my Firefox 95 in macOS and did the command-clicking link, it opens it as new tab just fine. Not sure why this fix is needed for this new version? Perhaps edge cases that are reporting this issue?
- lagrave 5y ago
  I have had this problem for years, and I am clearly not alone - see https://webapps.stackexchange.com/questions/151885/why-does-cmd-click-on-a-link-not-open-a-new-tab-in-gmail-firefox-mac/ https://webapps.stackexchange.com/questions/151885/why-does-...
  - Isthatablackgsd 5y ago
    I completely misunderstood the context. I realize it is about the Cmd +Clicking as in trackpad clicking, not the Cmd+Left-Mouse-Button originally. My apologies about the confusion. I am surprised this bug exists and I never encounter that kind of bug since I always use the mouse for the clicking.

SwiftyBug 5y ago

That called my attention too. Does that mean Firefox runs code specifically on Gmail?

wlpu 5y ago
Does Chrome?
coldpie 5y ago
I found this link from another bug that was marked fixed in 96. It contains all bugs marked to be included in the changelog for 96: https://bugzilla.mozilla.org/buglist.cgi?f1=cf_tracking_firefox_relnote&o1=equals&v1=96%2B https://bugzilla.mozilla.org/buglist.cgi?f1=cf_tracking_fire... From there I found this bug relating to cmd-clicking links in Gmail: https://bugzilla.mozilla.org/show_bug.cgi?id=1739929 https://bugzilla.mozilla.org/show_bug.cgi?id=1739929 You can find detailed discussion about what's going on there. I believe this is the ultimate fix: https://hg.mozilla.org/mozilla-central/rev/0fb0990124cf https://hg.mozilla.org/mozilla-central/rev/0fb0990124cf It does not appear to be specific to Gmail, no.
- hajhatten 5y ago
  Great find. I would've worded this differently then.
  - coldpie 5y ago
    Changelogs are really hard! Do you describe the actual bug that was fixed ("mouse click events in secure contexts would sometimes be ignored even if the web application didn't handle them") or do you describe the end-user impact ("middle-clicking links in gmail works again")? There's no right answer.
frankjr 5y ago
As others have pointed out, not in this case but in general yes - browsers do have website specific fixes for compatibility. Firefox: https://github.com/mozilla/gecko-dev/blob/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/browser/extensions/webcompat/data/injections.js https://github.com/mozilla/gecko-dev/blob/d107bc8aeadcc816ba... Safari: https://github.com/WebKit/WebKit/blob/86143cf226f227bac5ffad2dbcf1c0df64cbc69f/Source/WebCore/page/Quirks.cpp https://github.com/WebKit/WebKit/blob/86143cf226f227bac5ffad... I'm not sure what's the file for Chromium but I bet there's something similar.
- marcthe12 5y ago
  I know there is quirks file for webkit which is used to be safari and webkit was forked to blink which runs chromium so it depend if its still there.

Isthatablackgsd 5y ago

I loaded up my Firefox 95 in macOS and did the command-clicking link, it opens it as new tab just fine. Not sure why this fix is needed for this new version? Perhaps edge cases that are reporting this issue?

lagrave 5y ago
I have had this problem for years, and I am clearly not alone - see https://webapps.stackexchange.com/questions/151885/why-does-cmd-click-on-a-link-not-open-a-new-tab-in-gmail-firefox-mac/ https://webapps.stackexchange.com/questions/151885/why-does-...
- Isthatablackgsd 5y ago
  I completely misunderstood the context. I realize it is about the Cmd +Clicking as in trackpad clicking, not the Cmd+Left-Mouse-Button originally. My apologies about the confusion. I am surprised this bug exists and I never encounter that kind of bug since I always use the mouse for the clicking.