3 ms·

Just to be clear, the V8 "bug" was in the test runner code and caused mis-parsing of command line options for testing for non-SSE hardware. Not exactly a critic

• jeffbee 5y ago
  The way the bug arrived in that test runner is interesting. It sneaked in mid-review. Possibly bugs added in the middles of code reviews are more likely to get through. https://chromium-review.googlesource.com/c/v8/v8/+/2629465/3..5/tools/testrunner/base_runner.py https://chromium-review.googlesource.com/c/v8/v8/+/2629465/3... Personally, I prefer uniform lists with leading commas, because it's easier to add and remove lines for later, inevitable refactoring. For example, I prefer: things = [ 'foo' , 'bar' , 'baz' ] This drives some people crazy, but I think it's the One True Way.
  • aflag 5y ago
    Isn't things = [ 'foo', 'bar', 'baz', ] even better? In your case, if you want to add something to the beginning of the list you'll have to modify two lines.
    • jeffbee 5y ago
      Depending on the context, yes. But sometimes you are not allowed the last comma. ETA: Let me expand on why it's important to put the comma first. Which list is more clear to you: a , dog , weather , banana , b , car or a, dog, weather, banana, b, car With the leading commas, they all line up, and you can see them in a neat little row. I really prefer it especially in contexts where the trailing comma is not permitted, such as a SQL query: SELECT name , date , operation FROM stuff