3 ms·

Quite the opposite, the fixes should begin with a proper description of a problem. So the issue should get reported first. As for the fix, well, it's understan

Quite the opposite, the fixes should begin with a proper description of a problem. So the issue should get reported first. As for the fix, well, it's understandable that we developers have a certain degree of ownership and almost self-imposed duty to 'pitch-in', especially when qualified. Yet, in the open-source or not spirit, it should not really matter whether the issue fix was authored by the reporter, as long as the project/product got better. Sure, it feels appropriate to get one's own effort attributed, and in case of a sizable issue/PR it's very well important to also account the effort that goes into reviewing such contribution.

faho 5y ago
> Quite the opposite, the fixes should begin with a proper description of a problem. So the issue should get reported first. Especially for something as trivial as this, I don't see what value a separate issue adds. If you want to have something to link to e.g. for your release notes, a PR can also do that job. As an opensource maintainer, if someone opens an issue "Typo in docs" and a PR "Fix typo in docs #12345" five minutes later, I'll just tell them to not bother with the issue next time because that's just more clicking for me.
- PeterisP 5y ago
  The key problem is that a PR can't do the job because of the CLA-related difficulties described in the original article - the submitter can make the issue for the trivial change but not make a PR so the expectation is that the actual trivial change would have to be done by someone who has already handled the CLA overhead.
chris_wot 5y ago
I'm not sure I see the point for a one character typo. If the bug report is just thrown over the fence and this is what is encouraged, then I hope that the project doesn't start saying "please contribute a fix". If the project does say this, then the answer will be - I want to, but getting privileges to do so are too hard.

faho 5y ago

> Quite the opposite, the fixes should begin with a proper description of a problem. So the issue should get reported first. Especially for something as trivial as this, I don't see what value a separate issue adds. If you want to have something to link to e.g. for your release notes, a PR can also do that job. As an opensource maintainer, if someone opens an issue "Typo in docs" and a PR "Fix typo in docs #12345" five minutes later, I'll just tell them to not bother with the issue next time because that's just more clicking for me.

PeterisP 5y ago
The key problem is that a PR can't do the job because of the CLA-related difficulties described in the original article - the submitter can make the issue for the trivial change but not make a PR so the expectation is that the actual trivial change would have to be done by someone who has already handled the CLA overhead.

chris_wot 5y ago

I'm not sure I see the point for a one character typo. If the bug report is just thrown over the fence and this is what is encouraged, then I hope that the project doesn't start saying "please contribute a fix". If the project does say this, then the answer will be - I want to, but getting privileges to do so are too hard.