3 ms·
Its not that unintuitive once you understand async/await and how the tasks are resumed. Execution is yielded at an await. At that time the loop is not running
by jayd16 5y ago
Its not that unintuitive once you understand async/await and how the tasks are resumed. Execution is yielded at an await. At that time the loop is not running anywhere, its not even in a sleep state. The loop "terminates" by never being resumed.
- ianbicking 5y agoI'm assuming the loop would terminate with an exception... like `await events.pointermove` would raise some cancellation exception that would be silently captured.
- jayd16 5y agoSounds like the Abro runtime never resumes the tasks so how could they throw?
- ianbicking 5y agoOh... on second thought I realize the exception would have to come from `event.pointermove` (for example), and that object doesn't know anything about the receiver or whether it should cancel. So yeah, this does seem problematic.
- jayd16 5y agoAre you worried about when the case when an exception should be thrown from the thing being awaited? I'm not familiar with Arbo but usually the promise holds on to the exception until its observed. It could be that Arbo is configured to ignore the exception if the task is already cancelled.
- rexpan 5y agoThese 3 functions will stop on `await event.xxx` (if not, they will continue to execute or terminate). So when one of the functions is terminate https://github.com/pdubroy/handling-user-input/blob/main/abro.js#L54 https://github.com/pdubroy/handling-user-input/blob/main/abr... await Promise.any(fibers.map((f) => f.run())); fibers.forEach((f) => f.terminate()); Abro will reject the promise of these `await event.xxx` https://github.com/pdubroy/handling-user-input/blob/main/abro.js#L54 https://github.com/pdubroy/handling-user-input/blob/main/abr... this._promises.forEach(({ reject }) => reject()); Which will throw an Exception and exit the 2 other functions.
- xupybd 5y agoYeah that's still not the way the code reads. The closer the code behaves to the way it reads the better in my book.
- jayd16 5y agoHow does it read to you?
- bruce343434 5y agoWouldn't that result in a thread leak? (Or a "fiber" leak)
- jayd16 5y agoIf a task has yielded its not holding on to a thread. A loop that wasn't yielding would leak, though.