3 ms·
I'm not finding I agree with this review, but because the author has chosen their quotes selectively, I want to point out: "broken windows". The book uses the
by Jtsummers 5y ago
I'm not finding I agree with this review, but because the author has chosen their quotes selectively, I want to point out:
"broken windows". The book uses the turn of phrase, but does not (unless maybe in the original edition? I have the 20th anniversary one) actually quote the debunked theory beyond this phrase. Take it as the turn of phrase that it is, no need to read more into it than is present. If you don't like it, consider something more like "if you see trash on the ground, pick it up, don't step over it." Though that's a heck of a lot wordier. But about the selective quotes, let's take the whole phrase from the book:
> Don't leave "broken windows" (bad designs, wrong decisions, or poor code) unrepaired. Fix each one as soon as it is discovered. If there is insufficient time to fix it properly, then board it up. [emphasis mine] -- page 7
The emphasized part is what the reviewer didn't include. By only reading the first two sentences, sure it reads as a bit dogmatic. But reading the whole thing, it's clear that there is more to it. What does "board it up" mean? Well, they expand on it in the following sentences:
> Perhaps you can comment out the offending code, or display a "Not Implemented" message, or substitute dummy data instead. Take some action to prevent further damage and to show that you're on top of the situation. [emphasis in original]
That seems pragmatic to me, "I can't handle it properly now, but I'll do something that reduces the problem or draws attention so it can be properly handled later." In the JIRA-driven world, put in a new ticket.
They don't prescribe one answer or one set of answers to the problem, except to address it. Which is pragmatic because leaving garbage in a system is a really good way (over a few years, anyone who has worked on long-running systems will have experienced this) to end up with a load of garbage.
- rileymat2 5y agoIt is worse in software, people will copy and paste the broken windows all over the code base in new code.
- Jtsummers 5y agoI'm also dealing with that at work. Current situation: 11 files all derived from an initial baseline, there was only supposed to be a one line change for each (apparently the programmer had never heard the term "parameter"), everything else was supposed to be the same. However, what was two copies (and maybe easy to keep in sync) became 11 total, copied at different times and from different versions. They're all out of sync with each other and the end users now have to know 10 (one is correct) workarounds to deal with the 10 bad states the system can get into. And this isn't the only place this happened in this codebase, it's rampant. At least this fix is quick, annoying though.
- kgarten 5y agoI have the 20th anniversary edition. It quotes the debunked magazine article directly: "In inner cities, some buildings are beautiful and clean, while others are rotting hulks. Why? Researchers in the field of crime and urban decay discovered a fascinating trigger mechanism, one that very quickly turns a clean, intact, inhabited building into a smashed and abandoned derelict.[5]" Citation 5 is an article from the Atlantic from March 1982 https://www.theatlantic.com/magazine/archive/1982/03/broken-windows/304465/ https://www.theatlantic.com/magazine/archive/1982/03/broken-... Nobody thought to fix that for the 2019 edition?
- Jtsummers 5y agoFair enough, I apparently didn't look closely enough at that page and focused on "Tip 5" itself, the problem with using a physical book versus something searchable. Still, my primary issue with this review is the selective quoting that made the authors' views seem dogmatic in a way that they weren't. They specifically provide a pragmatic out versus stop-and-fix and rchaves neglected it to make a misleading point.