3 ms·
Good CR's are great, bad CR's are an incredible waste of time and you might as well not do them at all. We had a similar system where you trust people to know
by codeptualize 5y ago
Good CR's are great, bad CR's are an incredible waste of time and you might as well not do them at all.
We had a similar system where you trust people to know when you can skip the CR, worked great. We also ranked CR comments on importance, focussed on preventing issues, and avoid subjective discussions as much as possible. It meant CR's were mostly about bug catching, sometimes constructive conversations weighing pro's and cons, and other times making suggestions that may or may not be applied.
It's so much nicer than a dogmatic nitpicking CR culture that completely forgets about what's valuable and not. Maybe it's my relative small sample size but I feel they always go together.