3 ms·
I guess it depends a lot on the company's dev culture or team dynamic. In my current company, our code reviews are essentially a second set of eyes by a peer.
by system16 5y ago
I guess it depends a lot on the company's dev culture or team dynamic.
In my current company, our code reviews are essentially a second set of eyes by a peer. When things are "flagged" in code review it's never confrontational. Mainly they provide insight for those who haven't worked on the code base as long as to "why" things are the way they are, and it can open up discussions for improvements (or at least things to ponder for the backlog.) The odd time neat language or platform tricks are also learned.
I've worked in other places though where code reviews are done by rockstars or ninjas just looking for a reason to criticize or find fault with another's code so they can stroke their own ego. And if their code is ever questioned, expect a tantrum. Toxic environments like these say more about the company and people there than code reviews though.
Looking forward to the follow-up "no QA by default".