3 ms·
I think you’re missing context: I wrote most of this tool as part of another open source project (gVisor, which is the repository) and am not on or related to t
by amscanne 5y ago
I think you’re missing context: I wrote most of this tool as part of another open source project (gVisor, which is the repository) and am not on or related to the core Go team. Google is a huge company with tens of thousands of engineers, and for all intents and purposes this is a third-party tool.
It is also not duplicating any logic that I’m aware of, beyond the tangentially-related ssa issue? (Which is valid, but I would assume a low-priority problem for the Go team.)
The tool is very much tailored to our individual project needs, so TBH I’m not sure how consumable it is. This is why I would surprised to see it here, and being used as the basis for any kind of statement about Go itself. I’m certainly open to making it consumable if there’s interest, but I don’t think it’s what folks are assuming from the title? Hope that clarifies.
- Groxx 5y agothe "internally developed" part was only referring to the SSA pass, yeah. sorry, that was ambiguous. re consumable: in-struct is fine for the vast majority of cases I can think of, but my initial plans on anything like this are always "read, understand, then decide". so I'm plenty happy it's open source, it might give me ideas how to build things like this :) I'd have to dig in a lot deeper to see if it's immediately-applicable or not, but at a glance it sounds "good enough" + helps plug a very real, very dangerous gap. you may get some use if it's spread wider :) though at this point I might just wait for generics. building an ad-hoc guarded-value will be FAR easier then. I suspect the source will help me figure out how to build a couple more specialized tools though, I haven't dug into the SSA pass much yet.