3 ms·
> > you know what is a PR > This part doesn't make sense to me. A proper PR (pull request on GitHub, not public relations, just to be clear) contains a workin
by ivanche 5y ago
> > you know what is a PR
> This part doesn't make sense to me.
A proper PR (pull request on GitHub, not public relations, just to be clear) contains a working implementation of some feature or a bugfix. Ideally it also follows the style of the said project, is well tested etc.
If somebody opens a "PR" with no source code and the whole body of PR is, for example, "Replace your project with google docs" or even "s/.*/docs.google.com/", that's not a PR, that's wasting project maintainer's time.
If somebody opens a PR that says "Hey could you add feature X?" that's also not a PR. At best that's a feature request.